Review needed: notecase

[Ignacio Vazquez-Abrams]

On Wed, 2005-04-06 at 15:34 -0400, Toshio wrote:
> Another patch:
> %changelog
> * Wed Apr 6 2005 Toshio Kuratomi <toshio-tiki-lounge.com> 0.8.2-4
> - Eliminate dos2unix warning by only running on regular files.
> - Substitute paths in config.h from rpm macros.
> 
> The first part is trivial.  The second part is necessary in order to get
> help to work.

Works for me.

> The rest of my notes are at your discretion:
> * Notemeister is very similar to Notecase and its group is
> Applications/Productivity.  Since Notecase describes itself as an
> "outliner" I think that would be a more appropriate Group.

Agreed.

> * Except for prefix, paths in Notecase's build are hardcoded into the
> Makefile.

Lovely. Okay, let me look into this.

-- 
Ignacio Vazquez-Abrams <ivazquez at ivazquez.net>
http://fedora.ivazquez.net/

gpg --keyserver hkp://subkeys.pgp.net --recv-key 38028b72
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050406/5a55b6e3/attachment.sig>