Request for Preview: INADYN

[Ignacio Vazquez-Abrams]

On Thu, 2005-04-07 at 19:19 +0200, Jochen Schmitt wrote:
> http://www.herr-schmitt.de/pub/inadyn/inadyn-1.90-0.2.src.rpm
> 
> is a lightwight DynDNS client wrttien in puer C.

? Name and version macros at the top
? Incorrect release number
- Superflous Epoch 0
- Summary contains the package name
- What happened to %setup?
- Doesn't remove the buildroot at the beginning of %install
- No modes on install
- Doesn't use macros throughout %install
- Don't create %{_docdir} manually
- No changelog

Corrected spec file is attached.

-- 
Ignacio Vazquez-Abrams <ivazquez at ivazquez.net>
http://fedora.ivazquez.net/

gpg --keyserver hkp://subkeys.pgp.net --recv-key 38028b72
-------------- next part --------------
Name:           inadyn
Version:        1.90
Release:        1
Summary:        A Dynamic DNS Client.

Group:          System Environment/Daemons
License:        GPL
URL:            http://inadyn.ina-tech.net
Source0:        inadyn.v%{version}.zip
Source1:        inadyn.conf
BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

%description
INADYN is a dynamic DNS client. It maintains the IP address of a
host name. It periodically checks wheather the IP address stored
by the DSN server is the real current address of the machine that
is running INADYN.

%prep
%setup -q -c

%build
make -f makefile.linux

%install
rm -rf $RPM_BUILD_ROOT

mkdir -p $RPM_BUILD_ROOT%{_sbindir}
install -m 0755 bin/inadyn $RPM_BUILD_ROOT%{_sbindir}

mkdir -p $RPM_BUILD_ROOT%{_mandir}/man5
mkdir -p $RPM_BUILD_ROOT%{_mandir}/man8
install -m 0644 man/inadyn.8 $RPM_BUILD_ROOT%{_mandir}/man8
install -m 0644 man/inadyn.conf.5 $RPM_BUILD_ROOT%{_mandir}/man5

mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}
install -p -m 0600 %{SOURCE1} $RPM_BUILD_ROOT%{_sysconfdir}

%clean
rm -rf $RPM_BUILD_ROOT

%files
%defattr(-,root,root,-)
%doc readme.html
%{_sbindir}/inadyn
%{_mandir}/man*/*
%config /etc/inadyn.conf

%changelog
* Thu Apr  7 2005 Jochen Schmitt <Jochen at herr-schmitt.de> 1.9.0-1
- Initial RPM release
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050407/74d21f37/attachment.sig>