Request for Review: R, perl-Jcode, perl-OLE-Storage_Lite, perl-Spreadsheet-WriteExcel, perl-Unicode-Map, QuantLib, udunits

[Hunter Matthews]

On Mon, 2005-04-11 at 12:01, Tom 'spot' Callaway wrote:

> 
> R: 
> URL: http://www.r-project.org/
> SRPM: http://www.auroralinux.org/people/spot/R/R-2.0.1-8.src.rpm
> SPEC: http://www.auroralinux.org/people/spot/R/R.spec
> 

Try the published method for macros in URL's :

[thm at jade r]$ rpm -q --specfile R.spec --qf "$(grep -i ^Source
R.spec)\n"
Source0: ftp://cran.r-project.org/pub/R/src/base/R-2.0.1.tar.gz
[thm at jade r]$ wget
ftp://cran.r-project.org/pub/R/src/base/R-2.0.1.tar.gz
...
Resolving cran.r-project.org... 128.131.51.43
...
==> PASV ... done.    ==> RETR R-2.0.1.tar.gz ...
No such file `R-2.0.1.tar.gz'.

Other that, the package looks good - the build requires/devel requires
make sense, the spec is orderly, no signs of crack.


> QuantLib:
> URL: http://www.quantlib.org
> SRPM: http://www.auroralinux.org/people/spot/R/QuantLib-0.3.8-2.src.rpm
> SPEC: http://www.auroralinux.org/people/spot/R/QuantLib.spec
> 

I got an html file instead of hte tarball when using the Source url.

I'm also unsure why the %install section cp/mv docs around and then has
them as regular package files and not %doc targets.

I'm not saying thats wrong, I'm just asking why this instead?


I'll review the others as I get more time.
Oh - and is there review/qa checklist, cuz I'm just winging this
review...
-- 
Hunter Matthews                          Unix / Network Administrator
Office: BioScience 145/244               Duke Univ. Biology Department
Key: F0F88438 / FFB5 34C0 B350 99A4 BB02  9779 A5DB 8B09 F0F8 8438
Never take candy from strangers. Especially on the internet.