Request for Review: R, perl-Jcode, perl-OLE-Storage_Lite, perl-Spreadsheet-WriteExcel, perl-Unicode-Map, QuantLib, udunits

[Michael Schwendt]

On Mon, 11 Apr 2005 12:09:36 -0500, Tom 'spot' Callaway wrote:

> On Mon, 2005-04-11 at 18:18 +0200, Michael Schwendt wrote:
> > On Mon, 11 Apr 2005 11:01:16 -0500, Tom 'spot' Callaway wrote:
> > 
> > > udunits:
> > > URL: http://my.unidata.ucar.edu/content/software/udunits/index.html
> > > SRPM: http://www.auroralinux.org/people/spot/R/udunits-1.12.4-2.src.rpm
> > > SPEC: http://www.auroralinux.org/people/spot/R/udunits.spec
> > 
> > For reference:
> > https://bugzilla.fedora.us/show_bug.cgi?id=921
> 
> Thanks! Changes incorporated from that work into my spec, all blockers
> listed in that bz entry should not apply to my package.
> 
> udunits-1.12.4-3: http://www.auroralinux.org/people/spot/R/

Okay. I didn't want to start reviewing this today. But I couldn't resist
and clicked the link above for a single brief look. ;) Only the spec is
there, the src.rpm is missing.  The spec looks much cleaner than the one
in fedora.us bugzilla. But the hardcoded Perl vendor install paths,

  %{_libdir}/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/

are too fragile and should be replaced with

  %{perl_vendorarch}

which is predefined at least since FC3. Whether udunits only installs into
vendor paths (and never into site paths) or evaluates the INSTALLSITEARCH=...
argument for make install, would be something for a deeper review.