Request for Review: cyrus-imapd

[John Dennis]

On Sat, 2005-04-16 at 00:41 +0200, Enrico Scholz wrote:
> jdennis at redhat.com (John Dennis) writes:
> 
> > cyrus-imap was previously in fedora core and has now been moved to
> > extras. 
> > ...
> > To review just 'cvs co cyrus-imapd'
> 
> The location of the generated SSL certificates is a blocker for the
> current version. /usr/share/ssl might be shared between several hosts
> which would use the same certificate then. As certs are bound to DNS
> names, this will not work.  It is a very bad idea also to have secret
> SSL keys on an NFS share which /usr/share might be. /usr/share is
> reserved for fixed data provided by the distribution but not for
> configuration data (local SSL certs are configuration data).
> 
> Therefore, please move the SSL certs somewhere into /etc (e.g. like
> httpd).

The pem file is now located in the directory /etc/cyrus-imapd. If there
was an old pem file in the old location (/usr/share/ssl/certs) but not
one in the new location the %post install moves it to the new location.
If neither the old or new locations contain a pem file then %post
creates one in the new location.

Also the pem file was not listed as %ghost in the %files section, this
was probably an oversight, it is now a "ghost config noreplace" file.
-- 
John Dennis <jdennis at redhat.com>