request for review: tre

[Aaron Kurtz]

On Sat, 2005-04-23 at 07:21 -0400, Chris Ricker wrote:
> <http://www.oobleck.net/kaboom/fedora/srpms/tre-0.7.2-1.src.rpm>
> 
> tre is primarily a POSIX-compliant regexp library, but with support for 
> arbitrarily approximate matching. The package also includes agrep, a fuzzy 
> grep built using this library.
> 
> Anyone care to review / sponsor?

rpmlint says
W: tre summary-not-capitalized lightweight POSIX-compliant regexp
library
Is this an important style point here?

E: tre non-versioned-file-in-library-package /usr/share/man

various complaints about this for various files, which will make it
impossible to have multiple versions installed at once, but this doesn't
seem to truly matter.

E: tre standard-dir-owned-by-package /usr/share/man
E: tre standard-dir-owned-by-package /usr/share/man/man1

This on the other hand should be fixed. %{_datadir}/* is causing it, and
you don't want to do this. For one thing, both tre and tre-agrep
own /usr/share/man/man1/agrep.1.gz

W: tre one-line-command-in-%post /sbin/ldconfig
W: tre one-line-command-in-%postun /sbin/ldconfig

http://fedoraproject.org/wiki/ScriptletSnippets suggests but doesn't
require doing this as %post -p /sbin/ldconfig and so.

-- 
Aaron Kurtz <a.kurtz at hardsun.net             GPG Key ID: ED588CF2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050423/cdc61c92/attachment.sig>