Request for Review: libvisual-plugins

[Michael A. Peters]

On Thu, 2005-04-28 at 11:46 +0200, Aurelien Bompard wrote:
> Works for me with Amarok on FC3
> 
> About the spec file :
> * Files section : you could just delete the .la files in %install, with the
> command "find %buildroot%_libdir -type f -name "*.la" -exec rm -f {} ';'"
> and your files section would boil down to:
> %{_libdir}/libvisual
> %{_datadir}/libvisual
> %{_datadir}/libvisual-plugins
> (just an advice, you're the one maintaining in the end...)

done

> 
> * BuildRequirements
> You should add xorg-x11, because a makefile in the G-Force plugin dir uses
> the command "mkdirhier" (build fails in mach without it, succeeds with it)

done - though I would think requiring xorg-x11-devel would have pulled
that in. Bug in xorg spec file?

new package/spec file:

http://mpeters.us/fc_extras/libvisual-plugins.spec
http://mpeters.us/fc_extras/libvisual-plugins-0.2.0-0.3.src.rpm