Request for Review: bmp-flac

Tom 'spot' Callaway tcallawa at redhat.com
Thu Apr 28 23:04:27 UTC 2005


On Tue, 2005-04-19 at 22:23 +0200, Michael Schwendt wrote:

>  * Doesn't work for me. Steps to reproduce:
> 
>    1. take an arbitrary .WAV file
>    2. encode it with "flac filename.wav"
>    3. load "filename.flac" into BMP
>    
>    Result: Invalid FLAC File: "file:///..."
> 
>    The reason is that the "filename" argument passed to plugin code
>    is prefixed with "file://", which you need to strip off in the
>    plugin callback functions. I've ported xmms-fc to BMP a week
>    ago to have more code for testing BMP and ran into the same
>    issue.

Patch attached to resolve this blocker. Confirmed that it works (with
Dave Grohl's 1993 pre Foo Fighters demo tape!).

~spot
-- 
Tom "spot" Callaway: Red Hat Sales Engineer || GPG Fingerprint: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bmp-flac-2-filestrip.patch
Type: text/x-patch
Size: 1939 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050428/53235541/attachment.bin>


More information about the fedora-extras-list mailing list