Need help for open Requests

[Tom 'spot' Callaway]

On Wed, 2005-08-03 at 16:59 +0200, Jochen Schmitt wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hello,
> 
> I need further help to finish the folloing requests:
> 
> URL:
> https://www.redhat.com/archives/fedora-extras-list/2005-July/msg01529.html
> 
> Topic: New Package: highlight


Review: highlight

Good:

- rpmlint output ok
- meets naming guidelines
- license ok (GPL), text of license included, matches source
- code matches upstream
- builds fine on FC4 (x86)
- no missing BR, extra BR
- no locales
- no shared libs, headers
- not relocatable
- owns all directories it creates
- no duplicate files
- permissions ok
- %clean ok
- nothing in %doc affects runtime
- code, not content

Bad:

- Buildroot should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- macro use is inconsistent (don't mix %{buildroot} and $RPM_BUILD_ROOT)
- spacing is erratic in the format, makes it a little difficult to read
- no need to check if $RPM_BUILD_ROOT exists before deleting
- compiled with hardcoded CFLAGS, ignores $RPM_OPT_FLAGS
- %files is very overcomplicated
- Don't use %{release} to mark the file name, since that will need to be
incremented to fix bugs.

I cleaned up these blockers for you. Attached to this email is a patch
to enable use of $RPM_OPT_FLAGS, and a new spec. One point of note:

If your application creates a directory structure like this:

/usr/share/foo-1.1/bar/baz/qux

And you want to own all of the files and directories in that structure,
all you need to do in %files is:

%{_datadir}/foo-1.1

This will cause all of the files and directories within that package to
be owned by that package.

If you use the new spec (and the new patch), then highlight is APPROVED.
If you've got any questions about changes I made, feel free to ask me.

~spot
-- 
Tom "spot" Callaway: Red Hat Senior Sales Engineer || GPG ID: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: highlight-2.4-rpmoptflags.patch
Type: text/x-patch
Size: 339 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050803/b3970524/attachment.bin>
-------------- next part --------------
Name:		highlight
Summary:	A universal source code to formatted text converter
Version:	2.4
Release:	2%{?dist}
Group:		Development/Tools
License:	GPL
URL:		http://www.andre-simon.de/
Source0:	http://www.andre-simon.de/zip/%{name}-%{version}-1.tar.bz2
Patch1:		highlight-2.4-makefile.patch
Patch2:		highlight-2.4-rpmoptflags.patch
BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

%description
A utility that converts sourcecode to HTML, XHTML, RTF, LaTeX, TeX,
XSL-FO, XML or ANSI escape sequences with syntax highlighting.
It supports several programming and markup languages.
Language descriptions are configurable and support regular expressions.
The utility offers indentation and reformatting capabilities.
It is easily possible to create new language definitions and colour themes.

%prep
%setup -q -n highlight-%{version}-1
%patch1 -p1 -b .org
%patch2 -p1 -b .rpmoptflags

%build
make %{?_smp_mflags}

%install
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT
rm -rf $RPM_BUILD_ROOT%{_docdir}/highlight

%clean
rm -fr $RPM_BUILD_ROOT

%files
%defattr(-,root,root,-)
%doc ChangeLog AUTHORS README* COPYING TODO examples//
%{_bindir}/highlight
%{_datadir}/highlight
%{_mandir}/man1/highlight.1.gz

%changelog
* Wed Aug  3 2005 Tom "spot" Callaway <tcallawa at redhat.com> 2.4-2
- cleanups

* Sun Jul 24 2005 Jochen Schmitt <Jochen herr-schmitt de> 2.4-1
- Initial build