Review still needed: svgalib

[Hans de Goede]

Matthias Saou wrote:
> Hans de Goede wrote :
> 
> 
>>The svgalib package provides the SVGAlib low-level graphics library
>>for Linux.  SVGAlib is a library which allows applications to use full
>>screen graphics on a variety of hardware platforms. Some games and
>>utilities use SVGAlib for their graphics. For details on
>>supported chipsets, see man 7 svgalib (when svgalib is installed).
> 
> [...]
> 
>>The srpm can be downloaded from:
>>http://home.zonnet.nl/jwrdegoede/svgalib-1.9.21-2.src.rpm
> 
> 
> Attached is a quick patch to the spec file. Further reviewing is still
> needed, as I haven't tested the resulting package (the part on which
> you've invested the vast majority of the work).
> 

Thanks,

You can test it by running making te demos installed in 
/usr/share/doc/svgalib-devel-xxx/demos, just cd there and do a make.

Then run as root ./vgatest (choose a mode) and ./bg_test with bg_test
you should change vc and then switch back, after switch back it should 
have borders and a cross besides the white block. This is drawn in the 
background iow while switched away.


> Changes :
> - Unify tabs and spaces.
Ok
> - Fix main source URL.
Ok
> - Remove unneeded zero epochs.
Erm, there was an explicit epoch 0 in the RedHat packages back when it 
was still shipped by RH, should that remain then?
> - Remove -c (ignored) option to install, use -p instead.
Ah, I took that from the old spec. thanks for catching it.
> - Remove unneeded explicit(er) compression of man pages.
Hmm, I don't see that in you're patch?
> - Use %ifnarch instead of empty %ifarch + %else.
I already thought that that might work but I wasn't sure i've seen the 
empty %ifarch %else construnction elsewhere so I though %ifnarch did not 
exist or had issues.

Thanks again and Regards,

Hans