[Bug 165329] Review Request: roundup-0.8.4-1

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: roundup-0.8.4-1


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165329


gauret at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gauret at free.fr




------- Additional Comments From gauret at free.fr  2005-08-10 04:35 EST -------
- You can use http://dl.sourceforge.net/roundup/roundup-%{version}.tar.gz in the
URL tag, so it can be wget'ed directly
- insead of $RPM_SOURCE_DIR/roundup.conf you should use %{SOURCE1}, same thing
for %{SOURCE2} (which I would rename in roundup.init, but do as you want)
- please use the -p switch of install to preserve timestamps
- I'm not sure you can hardcode UID 58 for your roundup user. It could be used
already on some system. Just remove it, the -r switch will create a system
account anyway (100 < UID < 500)
- scriptlets should never echo anything. It could crash some frontends, or
simply be ignored by frontends. So:
  - Make sure everything goes to /dev/null with : > /dev/null 2>&1 (e.g. for
roundup-admin).
  - Don't echo things, write a README.Fedora instead
- don't delete your user on %postun, since the UID could change if the package
is reinstalled and the files will be unowned.
- you may want to stop the service only on erase, not on upgrade. See this page
: http://fedoraproject.org/wiki/ScriptletSnippets for more info dealing with
initscripts.
- you can use %{_initrddir} instead of %{_sysconfdir}/rc.d/init.d (yes, the name
is misleading, but it's the same)
- you can use disttag if you want to.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.