[Bug 165254] Review Request: plplot - Scientific plotting package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: plplot - Scientific plotting package


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165254


ed at eh3.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |ed at eh3.com
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From ed at eh3.com  2005-08-10 12:57 EST -------
Hi Orion, the package is looking good and heres the second half of the 
review that started in comment #5

needswork:
 - rpmlint reports:

     W: plplot-gnome no-documentation
     W: plplot-gnome-devel no-documentation
     W: plplot-octave no-documentation
     W: plplot-octave non-standard-dir-in-usr libexec
     E: plplot-tk no-dependency-on locales-tk
     W: plplot-tk-devel no-documentation
     E: plplot-tk-devel wrong-script-interpreter 
          /usr/share/plplot5.5.3/examples/tk/tk01 "xtk01"
     E: plplot-tk-devel wrong-script-interpreter
          /usr/share/plplot5.5.3/examples/tk/tk04 "xtk04"
     E: plplot-tk-devel wrong-script-interpreter
          /usr/share/plplot5.5.3/examples/tk/tk02 "xtk02"

   where I think everything can be safely ignored except for the
   "no-dependency-on locales-tk" which I just don't understand.
   Hopefully, someone else can explain it.  Anyone...?

 - plplot-gnome and plplot-tk both install shared libs so 
   please add a set of %post/%postun -p /sbin/ldconfig entries 
   for those two sub-packages

good:
 - needswork items from #5 are now OK
 - dir ownership looks OK
 - permissions look OK
 - code not content OK
 - use of -devel looks good
 - builds in mock on FC-4

Since the remaining bits appear to be minor, please fix them in 
CVS before the first build and I'll APPROVE.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.