[Bug 165615] Review Request: perl-Text-Template - Expand template text with embedded Perl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Text-Template - Expand template text with embedded Perl


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165615


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-08-16 09:15 EST -------
Review:

- rpmlint clean
- naming of package and spec is fine
- meets packaging guidelines
- license is same as perl, text included in package
- spec file written in English and is legible
- sources match upstream
- builds ok on FC4 and in mock for devel
- no locale data, libraries, pkgconfig, subpackages etc. to worry about
- not relocatable
- no directory ownership issues
- no duplicate files
- permissions OK
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime

Needswork:

BuildRequires: perl >= 1:5.6.1
perl is listed as being part of the minimal build environment in the packaging
guidelines, so this BR appears to be redundant. The explicit version requirement
doesn't seem to comes from the module itself.


Nitpick:

 " || :" after %check isn't really needed for an Extras package, unless you're
aiming for backwards specfile compatibility with legacy distros.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.