[Bug 166046] Review Request: libAfterImage - A generic image manipulation library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libAfterImage - A generic image manipulation library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166046





------- Additional Comments From bugs.michael at gmx.net  2005-08-17 14:59 EST -------
$ rpmlint libAfterImage-1.07-1.src.rpm 
W: libAfterImage spelling-error-in-description powerfull powerful


> %package devel
> Summary:  Development package for %{name}

Ambiguous. Suggest "Files needed for software development with %{name}"


%defattr missing in -devel %files section.


Suspicious error during %install:
[...]
/usr/bin/install -c -m 644 xwrap.h
/home/qa/tmp/rpm/tmp/libAfterImage-1.07-1-root-qa/usr/include/libAfterImage
cd apps; make install; cd ..
make[1]: Entering directory `/home/qa/tmp/rpm/BUILD/libAfterImage-1.07/apps'
make[1]: *** No rule to make target `../../libAfterImage/asimage.c', needed by
`../../libAfterImage/libAfterImage.so'.  Stop.
make[1]: Leaving directory `/home/qa/tmp/rpm/BUILD/libAfterImage-1.07/apps'
+ cd apps
[...]


While --enable-gdb may prevent compiler option -g from being removed
from default $RPM_OPT_FLAGS, it enables debug output in the library
(see "grep NO_DEBUG_OUTPUT * -R" and configure.in).


afterimage-config.in includes a hardcoded check for /usr/lib
which is supposed to prevent a standard library search path from
being added to the linker command-line with -L
(on x86_64 this check will fail and add -L/usr/lib64)

I believe the configure script looks for X in /usr/X11R6/lib also
on 64-bit platforms and probably won't find X libraries.


Why --enable-xlocale?


MMX -> This is from the included README:

> !!!!!!!!!!!!!!!!!!!!!!!!! MMX NOTICE !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
> Note:
> libAfterImage gets compiled with inline MMX assembly enabled.
> If you have CPU that does not support it - you'll
> have to manually turn that off by using --disable-mmx-optimization
> option to configure script.
> Otherwise you gonna get wierd segfaults and Illigal Instruction
> exceptions.
> !!!!!!!!!!!!!!!!!!!!!!!!! MMX NOTICE !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.