[Bug 166087] Review Request: quarry - A multi-purpose board game GUI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: quarry - A multi-purpose board game GUI


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166087





------- Additional Comments From gajownik at gmail.com  2005-08-19 04:17 EST -------
Few remarks:
- you still don't use find_lang macro :P

Remove this line:

%{_datadir}/locale/*/LC_MESSAGES/quarry.mo

and change "%files" to:

%files -f %{name}.lang

You have to do this in this way because "%_install_langs" macro in
/root/.rpmmacros file will not work. find_lang macro allows users to install
only _needed_ translations.
- in my build envinronment this line is unnecessary:

mkdir -p $RPM_BUILD_ROOT%{_datadir}/applications

desktop-file-install creates this directory automatically
- close brackets at the end of your e-mail adress in the changelog section
- please add to the desktop file "GenericName" tag, for example:

GenericName=Multi-purpose board game GUI

- IMHO line "X-Desktop-File-Install-Version=0.10" in the desktop file is
unnecessary. desktop-file-install program will add it automatically.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.