[Bug 165661] Review Request: perl-Tree-Simple

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Tree-Simple


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165661


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-08-19 12:45 EST -------
Review:

- rpmlint not quite clean - see below
- package and spec file naming is OK
- package meets guidelines
- license is same as perl
- spec file written in English and is legible
- source matches upstream
- builds OK on FC4 and in mock for devel
- BR's OK
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership issues
- Tree/Simple.pm installed with wrong permissions - see below
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime

Issues:

- rpmlint output
E: perl-Tree-Simple script-without-shellbang
/usr/lib/perl5/vendor_perl/5.8.6/Tree/Simple.pm
This script does not begins with a shellbang. It will prevent its execution.

Fix by adding to %setup:
chmod -x lib/Tree/Simple.pm

- BR: perl is redundant
- find of empty .bs files is redundant
- add BR: perl(Test::Pod) for better test coverage; this is not pulled in by
  the perl(Test::Pod::Coverage) >= 1.04 BR.

These can be fixed post-import.

Approved.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.