[Bug 165892] Review Request: xsupplicant

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xsupplicant


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165892





------- Additional Comments From jamatos at fc.up.pt  2005-08-19 14:17 EST -------
+ package builds in mock for x86_64  
+ rpmlint check  
  rpmlint xsupplicant-1.2-1.fc4.x86_64.rpm  
E: xsupplicant non-readable /etc/xsupplicant.conf 0600  
  
  (clearly here rpmlint is wrong, xsupplicant configuration should not be  
public)  
  
+ package follows name convention and the spec file is correctly named  
+ no locales, libraries, subpackages, pkgconfigs etc. to worry about  
+ not relocatable  
+ no directory ownership or permissions issues  
+ no duplicate files  
+ the license is correct (GPL) and it ships in the package  
+ the spec file is in English and it is readable  
+ the source file is the same as upstream (sha1sum agrees)  
+ build requires are correct (*)  
  
So the package is APPROVED.  
  
(*) Is the any special reason to require byacc and not bison? I am just  
curious. :-)  
  

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.