[Bug 165456] Review Request: Enables hotkey functions for Toshiba laptop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Enables hotkey functions for Toshiba laptop


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165456





------- Additional Comments From matthias at rpmforge.net  2005-08-23 08:51 EST -------
No, the init script is definitely not ok the way it is. There is also a
"RETVAL=$?" after "echo" (always true) instead of after the "killproc" call
which will have the script return a wrong exit status in some occasions.

Attached is a completely new init script. It fixes all the issues I've seen, but
is completely untested, so please give it a try in case I've missed something.
Note that I've enabled the service by default for runlevels 2345. This is
something we don't want to do often, but for such a specific service that
doesn't do any kind of network access, it should be considered ok, and will save
the end user the step of manually enabling the service.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.