[Bug 165913] Review Request: gquilt - a PyGTK GUI wrapper for quilt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gquilt - a PyGTK GUI wrapper for quilt


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165913


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tcallawa at redhat.com  2005-08-23 14:12 EST -------
Review:

Good:
- rpmlint checks returns only E: gquilt only-non-binary-in-usr-lib, which can be
ignored, since this is python.
- package meets naming/packaging guidelines
- license (GPL) ok, license text in %doc, matches source
- spec legible, in am.english
- sources match upstream
- compiles on FC4 (ppc)
- no missing BR, no unnecessary BR
- no locales, no libs
- not relocatable
- owns all directories it makes
- no duplicate %files
- no need for -docs, -devel
- code not content
- %clean ok
- macros are consistent
- nothing in %doc affects runtime

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.