[Bug 166252] Review Request: perl-Gnome2-Canvas

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Gnome2-Canvas


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166252





------- Additional Comments From jspaleta at gmail.com  2005-08-25 10:00 EST -------
(In reply to comment #10)

Okay so I've done some more testing beyond the supplied demo program. Whatever
the build error is that is producing the "Unrecognized argument in LIBS ignored:
'-pthread'" message it doesn't appear to be causing a functional problem on my
system.  Of course I'd like to clean this up.. but it doesn't appear to be
having a functional impact at all from my simplistic functionality tests. I'm
inclined to let this through since there is no functional impact.

Instead of waiting for upstream to look into this, perhaps its most appropriate
to apply a simple patch the the generated Makefile.  You can correct for
whatever mistake  perl Makefile.PL is doing by adding "-pthread" to
the EXTRALIBS and LDLOADLIBS definitions. 

-pthread is a valid argument to both the linker and to gcc so I'm not really
sure why Makefile.PL is throwing the arguments away. 

So if you can regenerated a spec that includes the OPTIMIZE patch and the patch
to add -pthread to the generated Makefile, I will feel comfortable getting this
review finished up.

-jef

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.