[Bug 166713] Review Request: perl-GnuPG-Interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-GnuPG-Interface


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166713





------- Additional Comments From paul at city-fan.org  2005-08-26 02:15 EST -------
(In reply to comment #3)
> I dislike the magic being used to apply the patch conditionally.
> As I don't have FC3 anymore, I can't easily test, so let me ask: Does Patch1
> cause any harm/failures/malfunctions on FC3?
> 
> - If no, then I'd propose you to apply the patch unconditionally.
> 
> - If yes, then I'd propose to replace the gpgversion detection magic by using 2
> different versions of the spec file (one for FC3 and one for FC4).

"make test" fails on FC3 if the patch is applied because the output format from
gpg is not recognised.

Regarding version detection magic, I'm personally in favour of it (at least if
it's fairly clear what's going on - you might want to add a comment about it in
the spec) because I can maintain a single spec file for all branches (currently
devel, FC-4, and Fc-3), which makes future changes easier to do. Others, like
Ralf, clearly prefer to maintain separate spec files when necessary in each
branch, which will be clearer to read and less error-prone if there's ever an
issue with the "magic". But I think it's the packager's choice, not a policy issue.

> Missing:
> Requires: gpg

Yes, this is needed (or Requires: gnupg).


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.