issue with make dist/cvs commit

[Michael Schwendt]

On Sat, 27 Aug 2005 12:18:45 +0200, Patrice Dumas wrote:

> I am hit by something that looks like a bug(?) of the tag/build system. 
> Here is what I did (for pam_ssh)
> 
> First there was no %{?dist} in the spec file. I did
> 
>   cd devel
>   make tag 
>   make plague
> 
> Then I wanted to request a build in FC-4. So
> 
>   cd FC-4
>   make tag
>  -> it complains that the tag must be unique
> 
> So I add the tag. I don't commit. Still in FC-4 I do
> 
>   make tag
> -> error about the fact that I didn't commit.
> 
> So I commmit. No problem. Then I try to make the build
> 
>   make plague
> -> pam_ssh.spec not tagged with tag pam_ssh-1_91-8_fc4
> 
> If I try to re-tag,I get 
> 
>   make tag
> ERROR: Tag pam_ssh-1_91-8_fc4 has been already created.
> 
> 
> 
> So it seems that when I did "make tag" without commiting prior the tag was
> created even though there was an error.
> 
> 
> I see a possibility to overcome that issue: bump the release number. But I
> wanted to report it anyway.

It is possible to tag the files with "cvs tag" and the right options.
It is also possible to set the same options in an environment variable,
where "make tag" fetches them. However (!), documenting this in a
prominent place opens up the door for abuse and accidents.