New package: libnjb

[Ralf Corsepius]

On Mon, 2005-08-01 at 15:02 +0200, Linus Walleij wrote:
> On Fri, 29 Jul 2005, Ralf Corsepius wrote:
> 
> > You should make this spec files more compliant to FE-conventions.
> > Please read http://fedoraproject.org/wiki/PackagingGuidelines
> 
> I have now read and tried my very best to comply with all packaging 
> guidelines and the stuff mentioned in the packaging review guidelines as 
> well. See:
> 
> http://www.df.lth.se/~triad/fedora/libnjb-2.2.1-2.fc4.src.rpm
> 
> Would you approve this package now?

There are still some blocking issues:

- You should either use
Requires(pre): /sbin/ldconfig
Requires(post): /sbin/ldconfig
or 
%pre -p /sbin/ldconfig
%post -p /sbin/ldconfig

- The package must not own %{_libdir}

Besides these, further other minor issues (mostly personal preference)
exist - Let me propose the patch below.

Unless somebody else objects I'd approve the package, then.

Ralf

-------------- next part --------------
A non-text attachment was scrubbed...
Name: libnjb.spec.diff
Type: text/x-patch
Size: 3540 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050801/2770e6b7/attachment.bin>