Request for review (round3): libxslt-plugin-regexp and libxslt-plugin-dates-and-time

joel reed joelwreed at comcast.net
Wed Aug 3 01:20:41 UTC 2005


On Tue, Aug 02, 2005 at 01:01:59PM -0400, Brian Pepple wrote:
> On Tue, 2005-08-02 at 11:04 -0500, Tom 'spot' Callaway wrote:
> > On Mon, 2005-08-01 at 21:19 -0400, joel reed wrote:
> >  
> > > hmm, no feedback this time. can i assume they are now acceptable?
> > 
> > No, don't assume that.
> > 
> > In an initial look, I notice a couple of things.
> > 
> > - You really should consider using some newlines in the spec file. It
> > significantly helps legibility if you break it up into groups.

ok, i'll add some back, but last two rounds people were complaining
about extra whitespace. i appreciate your feedback and will make
the changes, but ouch this is painful.

jr




More information about the fedora-extras-list mailing list