Request for review: stripesnoop

[Chris Grau]

On Thu, Aug 04, 2005 at 11:25:51PM +0200, Ralf Ertzinger wrote:
> Hi.
> 
> Chris Grau <chris at chrisgrau.com> wrote:
> 
> > Bad:
> > 
> > - -devel requires %{name}-%{version}-%{release}
> 
> Is it bad that it requires it or that it does not require it?

It's bad that the requires line didn't read "%{name} =
%{version}-%{release}".  I'll be more specific in my critique next time.

> > The compiler warnings look harmless to me.  It's just fgets() and the
> > string buffer appears to be handled fine.  It could be worse, the author
> > could have used gets(), but this isn't a code review.
> 
> This means that the author assumes that the fgets always succeeds, which
> is usually not a good idea.