Request for review: scanssh

[José Pedro Oliveira]

Oliver,

> 
> Summary: fast SSH server and open proxy scanner
> 
> SRPM and Spec, as usual:
> http://filelister.linux-kernel.at/mod_perl?current=/packages/FC_EXTRAS_APPROVAL/scanssh

Status: NEEDSWORK

MD5SUMS:
3e27c048098097ffb475dd1c810c3258  scanssh-2.1-2.src.rpm

e6e2be8659b131960d768c857844bd05  scanssh-2.1-hide.patch
9fab4253b56b2d15367d4872b370cdcb  scanssh-2.1.tar.gz
08c6cd0ccaa97c250b8299543f9ebca0  scanssh.spec

Sources:
* scanssh-2.1-hide.patch: URL ?
* scanssh-2.1.tar.gz: MD5 digest checked OK against upstream tarball

Good:

* Package name follows standard
* Main source MD5 digest checked OK against upstream tarball
* The URL is valid
* File permissions verified
* License verified
* Build Requirements list is complete
* Builds without problems in FC-3 and FC-4

Needswork:

* the package isn't built with the distribution flags (RPM_OPT_FLAGS).
  The package configure doesn't inherit the CFLAGS initialized
  my the %configure macro.  A workaround is to pass them to make:
  ...
  -%{__make} %{?_smp_mflags}
  +%{__make} %{?_smp_mflags} CFLAGS="-Wall $RPM_OPT_FLAGS"
  ...
* No need to explicit add the requiments list
  (rpm detects the shared libraries)
* Package group not valid (rpmlint)
  ...
  -Group:                 Networking/Other
  +Group:                 Applications/Internet
  ...
* Capitilize the Summary info (rpmlint)

Other notes:

* The patch is vailable online? Maybe add its URL?
* You don't need to detect if RPM_BUILD_ROOT is the root
  directory (%install and %clean sections)
  ...
  -[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
  +rm -rf $RPM_BUILD_ROOT
  ...
* Maybe drop the TODO file from the %doc list?
  Doesn't appear to have much (critical) information.


jpo
-- 
José Pedro Oliveira
* mailto: jpo at di.uminho.pt * http://gsd.di.uminho.pt/jpo *
* gpg fingerprint = F9B6 8D87 859D 1C94 48F0 84C0 9749 9EB5 91BD 851B *
http://conferences.yapceurope.org/2005/ * http://braga.yapceurope.org/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 251 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050805/976299a0/attachment.sig>