[Bug 165258] Review Request: Profile HMM software for protein sequence analysis

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Profile HMM software for protein sequence analysis


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165258





------- Additional Comments From matthias at rpmforge.net  2005-08-06 05:46 EST -------
A few questions first :
- Why not use %{version} in the source line? It lowers the eventuality of
changing the "Version:" line, forgetting to change the source on too, and ending
up with a package that contains the old version by seems like it contains the
new one.
- Same logic applies to the "%ifarch ppc" part : If you have do this, you'll
have less chances of forgetting to update the configure options for either of
ppc or non-ppc :

%configure \
%ifarch ppc
    --enable-altivec \
%endif
    --enable-lfs \
    --enable-threads

- Shouldn't the "make check" go into a separate %check section?

One remark to point out that the DESTDIR patch is somewhat overkill, and it
would have been easier to simply use :

make install BINDIR=$RPM_BUILD_ROOT%{_bindir} MANDIR=$RPM_BUILD_ROOT%{_mandir}

Since the Makefile only uses these two locations.

Last, you don't seem to include any of the files from the "tutorial" directory,
is that on purpose?

Other than that, things look pretty good :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.