[Bug 165265] Review Request: libnjb

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libnjb


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165265





------- Additional Comments From rc040203 at freenet.de  2005-08-07 00:24 EST -------
# rpmlint /tmp/libnjb-2.2.1-3.src.rpm
W: libnjb hardcoded-packager-tag Linus

- Remove from the spec:
if [ -d $RPM_BUILD_ROOT ]; then rm -r $RPM_BUILD_ROOT; fi
This is not useful.
rm -rf $RPM_BUILD_ROOT
has the same effect


- Missing dependendies
# rpm -q --requires -p libnjb-devel-2.2.1-3.i386.rpm
libnjb = 2.2.1-3
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1

Requires: ncurses-devel, zlib-devel, libusb-devel
are missing

- Many questionable conditionals inside of the spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.