New package: kadu

[Dawid Gajownik]

Dnia 08/02/2005 08:00 PM, Użytkownik Mariusz Wasiluk napisał:
> Hi!

Hi :]

> SPEC: http://kadu.net/~nastian/kadu.spec

There are few problems with your package:
- timestaps in SRPM are not preserved:
	http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps

- kadu.desktop file should be fixed:

[rpm-build at X SOURCES]$ desktop-file-validate kadu.desktop
kadu.desktop: error: required key "Encoding" not found
kadu.desktop: warning: file contains key "MiniIcon", usage of this key
is not recommended, since it has been deprecated
kadu.desktop: warning: boolean key "Terminal" has value "0", boolean
values should be "false" or "true", although "0" and "1" are allowed in
this field for backwards compatibility
[rpm-build at X SOURCES]$

- you should proved full URL to Source0:
http://www.kadu.net/download/stable/%{name}-%{version}.tar.bz2

- don not hardcode paths. For example,

	%define         _libdir         /usr/lib

will not work properly on 64-bit box. Some macros are already defined, 
so you don't need to redefine them:
	http://fedoraproject.org/wiki/Extras/RPMMacros

%define         _modulesdir     %{_datadir}/%{name}/modules
%define         _themesdir      %{_datadir}/%{name}/themes
%define         _translationsdir        %{_datadir}/%{name}/translations

IMHO rest of definitions are not needed.

- some lines in descriptions are longer than 80 characters
	http://fedoraproject.org/wiki/PackagingGuidelines#summary

Well, we know both that kadu will be mostly used in Poland but I'm not 
shure is it OK to include in spec file Polish translations of 
description and summary fields :/

- summary should not end with dot (for example kadu-arts_sound package)

- subpackages should require main package with the same version AND release:

Requires:       %{name} = %{version}-%{release}

- devel package is missing "Requires: qt-devel"
Type: "kadu-config --libs --cflags" and you will see :]

	http://fedoraproject.org/wiki/PackagingGuidelines#Requires

- instead of "export QTDIR=/usr/lib/qt-3.3" you should use:

unset QTDIR || : ; . /etc/profile.d/qt.sh

or this → https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=161343#c3

- don't remove $RPM_BUILD_ROOT/usr/lib/debug directory

- in file section:
/usr/share/pixmaps/* → %{_datadir}/pixmaps/*
%{_bindir}/kadu-config in devel package has wrong permissions (shoud be 
executable)
devel package includes %{_libdir}/debug
- you shoud install kadu.desktop file using this command:

desktop-file-install --vendor fedora \
         --dir %{buildroot}%{_datadir}/applications\
         %{SOURCE1}

Use rpmlint - it's a really helpful utility.
	http://fedoraproject.org/wiki/PackagingGuidelines#rpmlint

BTW new package process has changed:
	http://fedoraproject.org/wiki/Extras/NewPackageProcessMarkTwo
and maybe it would be better to open bugzilla submission. It's really 
easy to lost packgage review request in fedora-extras mailing list :/

-- 

   ^_*