[Bug 165265] Review Request: libnjb

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libnjb


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165265





------- Additional Comments From bugs.michael at gmx.net  2005-08-09 15:49 EST -------
> I was sort of wondering if "relocatable" is to be understood as
> "relocatable after packaging" 

Yes, it is.

$ rpm -qpi libnjb-2.2.1-4.i386.rpm  | grep Reloc
Name        : libnjb                       Relocations: /usr 

Files starting with /usr can be relocated at install-time.
Also see "man rpm":

       --relocate OLDPATH=NEWPATH
              For relocatable binary packages, translate all file  paths  that
              start with OLDPATH in the package relocation hint(s) to NEWPATH.
              This option can be used repeatedly if several OLDPATH’s  in  the
              package are to be relocated.

> (and if there still is some issue, I can fix it) as far as you set the
> apropriate search paths for libraries and pkgconfig. For example it can
> be relocated to /opt/lib without any problems, many users have done this.

Basically, it's relocatable except for the pkgconfig file, which contains 
hardcoded references to /usr, which would break when installed in /opt e.g.
*That* plus the package dependencies on non-relocatable packages make the 
decision to mark libnjb as relocatable, a questionable decision. Another
pretty serious problem with relocatable packages is that you must keep them
relocatable forever, which is a common pitfall when a library starts
accessing data files in %_datadir, for instance.

> also noticed that the pkgconfig dirs used are better off as a 
> Requires: pkgconfig line.

It's a soft-requirement, since libnjb.so and headers are in standard search 
paths. It would be a hard-requirement, if an application were unlikely to
find libnjb and headers without using pkg-config.

> The .la files are mystically called static libs in the package review
> guidelines, that's why that comment was so strange 

Documentation bug.

> But! %{docdir} is NOT defined, instead we have to use %{_docdir} which

%_docdir is a global, no need to define it.

> I set:
>
> Docdir:    %{_defaultdocdir}

Not necessary either.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.