[Bug 165265] Review Request: libnjb

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libnjb


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165265





------- Additional Comments From bugs.michael at gmx.net  2005-08-09 17:33 EST -------
You are free to use %{_defaultdocdir} instead if you prefer that.

> However after using Docdir: %{_defauldocdir} inside a specfile
> it exists and can be used.

Again, %_docdir comes predefined. No need to define "Docdir:" something.
I just introduces mistakes and possibly influences things like the
following. Your %doc files are located in

  /usr/share/doc/libnjb-devel-2.2.1/

while your html files are located in

  /usr/share/doc/libnjb-2.2.1/

and both in one package.

> %dir %{_libdir}/pkgconfig

That directory does not belong into your package. And hence your package
should not own it. Either "Requires: pkgconfig" or leave the directory
unowned. Installing package pkgconfig _after_ libnjb-devel would even
overwrite the directory permissions.

I don't know how else to explain it. One last try: libnjb-devel works well 
without pkg-config, since library and headers are in standard search path.
Due to this installing and using pkg-config is optional. If you feel like
making it a requirement, add the "Requires: pkgconfig". That package exists
in Core, so nobody should complain if it were needed. However, to add the
dependency just to get the package that owns %_libdir/pkgconfig/ would be
exaggeration IMHO. 

Directory ownership _is_ important in other cases (and that's why it's
in the packaging guidelines). For directories like %_libdir/pkgconfig/ or
%_datadir/aclocal/ it's not. That's IMHO. YMMV.


> OK then I guess we are all done because the -5 version is hardcoded to
> /usr as suggested

Defining "Prefix: /something" still marks the package as relocatable.
Suggested fix: Don't define "Prefix:".


Such a small package, oh so many things to make it complicated. ;-)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.