[Bug 165537] Review Request: athcool - enabling/disabling Powersaving mode for AMD processors

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: athcool - enabling/disabling Powersaving mode for AMD processors


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165537


ed at eh3.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |ed at eh3.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From ed at eh3.com  2005-08-10 09:01 EST -------
Hi Dawid, this is a small and very nicely done RPM.  Welcome to Fedora 
Extras!

Heres the review notes:

a suggestion:
 - Would you be willing to change the Summary to 
   "Enables/disables Powersaving mode for AMD processors" ?

good:
 - specfile is very easy to read
 - rpmlint OK
 - spec and package naming OK
 - source matches upstream
 - license is GPL and included in %doc
 - builds in mock on FC-4
 - all dirs are owned
 - code not content
 - scriptlets look good

and everything else looks good.  I didn't try running the package since 
the only Athlon I have handy is a backup machine and I'd be very sad if 
it had any filesystem corruption (and, yes, I realize that its a very 
small risk).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.