[Bug 165398] Review Request: Python array manipulation and computational library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Python array manipulation and computational library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165398


ed at eh3.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From ed at eh3.com  2005-08-11 00:02 EST -------
Hi Orion, heres the review notes:

needswork:
 - rpmbuild warns about files being list twice such as:

     warning: File listed twice: 
       /usr/lib/python2.4/site-packages/numarray/__init__.pyo

   so please take a closer look at

     %{python_sitelib}/numarray/
     %ghost %{python_sitelib}/numarray/*.pyo

   in the files section -- I don't know whether its a bug or 
   something that can be ignored or just my ignorance of the 
   %ghost macro...

good:
 - license looks OK and is included although one has to execute:

     $ python
     >>> import numarray
     >>> print numarray.__LICENSE__

   to read it (which seems OK since it appears to be what the 
   authors wanted and they went to some effort to have it that 
   way)

 - rpmlint reports warnings for the 16 *.h files but then the
   package does Provide: python-numarray-devel so someone could 
   easily split them off at a future date

 - specfile is easy to read and looks OK
 - names look OK
 - source matches upstream
 - builds nicely in mock on FC-4
 - Requires and BuildRequires look OK
 - dir ownership looks OK
 - code not content
 - no segfaults encountered

and I don't know what to say about the %ghost bit and the files-listed
-twice warning.  If it weren't so late right now I'd Google for some
examples and/or documentation.  But I need sleep...  ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.