[Bug 165666] Review Request: Graph Visualization Tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Graph Visualization Tools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165666





------- Additional Comments From rc040203 at freenet.de  2005-08-11 06:00 EST -------
Not a formal review, just some remarks on the spec files:

- BuildRoot not conforming to FE conventions:
BuildRoot:		%{_tmppath}/%{name}-root

- Questionable:
%{expand: %%define optflags %{optflags} -ffast-math}

- Probably wrong:
%configure ....
  transform='s,x,x,' \
[If this is required, the configure script is utterly broken.]

This is twice questionable:
1. Using -ffast-math is questionable by itself. I recommend against it.
2. The expand. Pass CFLAGS="$RPM_OPT_FLAGS <more>" to configure instead.

- Missing
Requires(post): %{_bindir}/dot
Requires(postun): %{_bindir}/dot


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.