[Bug 165361] Review Request: NetHack, a rogue-like single player dungeon exploration game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: NetHack, a rogue-like single player dungeon exploration game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165361





------- Additional Comments From joost at cnoc.nl  2005-08-11 09:09 EST -------
Ok, this is my first review, so be patient with me...

Further I'm not sure if I may assign this bug to myself, since I have
cvs-access, but none of my packages are approved yet. . .

Good:

- rpmlint output 

E: nethack obsolete-not-provided nethack-falconseye
W: nethack unstripped-binary-or-object /usr/games/nethack/nethack
E: nethack zero-length /var/games/nethack/logfile
E: nethack zero-length /var/games/nethack/record
E: nethack zero-length /var/games/nethack/perm
E: nethack non-standard-dir-perm /var/games/nethack 0775
E: nethack non-standard-executable-perm /usr/games/nethack/nethack 02755
E: nethack non-standard-dir-perm /var/games/nethack/save 0775

* Comments about rights can be disregarded
* Empty files are ok
* /usr/games/nethack/nethack is also ok

- meets naming guidelines
- license ok (GPL), text of license included, matches source
- builds fine on FC3 (x86) 
- builds on mock
- code matches upstream
- no locales
- no shared libs, headers
- owns all directories it creates
- permissions ok
- no missing BR, extra BR
- not relocatable
- %clean ok
- nothing in %doc affects runtime
- code, no content

Possibly not so good:
* Why do you use source2, instead of source1 for the desktop-file?
* Why is there only debug-information for nethack-recover?
* I don't know anything about the history with Falconseye, could you explain that?
* there is a man-file for the 'recover' command, but actually it's nethack-recover
* there are man files for the non-provided dlb, dgb_comp and lev_comp binaries
* the licence file is at two places, in %doc and /usr/games/nethack, maybe you
should remove the second one
* and the /usr/games/nethack and /var/games/nethack directories. Shoudn't that
be called nethack-3.4.3 ?



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.