[Bug 165551] Review Request: perl-Number-Compare
bugzilla at redhat.com
bugzilla at redhat.com
Fri Aug 12 17:25:12 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Number-Compare
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165551
paul at city-fan.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |paul at city-fan.org
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From paul at city-fan.org 2005-08-12 13:25 EST -------
Review:
- rpmlint clean
- package/spec follows naming guidelines
- package follows packaging guidelines
- license is OK - same as perl
- spec file is in English and is perfectly legible
- source matches upstream
- build fine in mock for -devel (i386)
- no explicit BRs
- no locales, libraries, headers, pkgconfigs, subpackages to worry about
- not relocatable
- directory ownership OK
- no duplicate files
- file permissions OK
- %clean present and correct
- macro usage is consistent
- code, not content
- no large docs
- manpage does not affect running of package
- package appears to work
Would suggest adding to %description:
Now this would be very pointless, if Number::Compare didn't understand
magnitudes.
The target value may use magnitudes of kilobytes (k, ki), megabytes (m, mi),
or gigabytes (g, gi). Those suffixed with an i use the appropriate 2**n
version in accordance with the IEC standard:
http://physics.nist.gov/cuu/Units/binary.html
Please also note Comment #6 re empty .bs files.
Approved.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list