[Bug 165878] Review Request: kadu

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kadu


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165878


gajownik at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: kadu        |Review Request: kadu
                 CC|                            |gajownik at gmail.com




------- Additional Comments From gajownik at gmail.com  2005-08-15 13:22 EST -------
It seems to be your first pacakge in Fedora Extras, so the first review must be
done by you sponsor. I may only help you cleaning up the spec file :]

- use %{dist} in the Release tag instead of hardcoding 'fc4'.
http://fedoraproject.org/wiki/Extras/BuildRequests
http://fedoraproject.org/wiki/DistTag

I'm not shure whether it's still true but few people on Fedora Extras were
suggesting adding %{dist} after importing package info CVS.
- remove spaces after "Applications/Internet"
- MacOSX → Mac OS X (?)
- Alsa → ALSA
- you have removed dots from the %description fileds. Please revert your
changes. They're not allowed only at the end of a "Summary".
- I'm not a native English speaker but "Modules aRts for Kadu" sounds weird to
me. Maybe "aRts module for Kadu" would be better?
- according to this page →
http://fedoraproject.org/wiki/PackageNamingGuidelines#NormalPackages you should
avoid using underscore in the package name.
- this files could be marked as %doc:

%{_datadir}/%{name}/AUTHORS
%{_datadir}/%{name}/README
%{_datadir}/%{name}/ChangeLog
%{_datadir}/%{name}/COPYING
%{_datadir}/%{name}/HISTORY
%{_datadir}/%{name}/THANKS

- you can also pass to this options the desktop-file-install program:

 --add-category InstantMessaging

http://standards.freedesktop.org/menu-spec/latest/apa.html  

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.