[Bug 166004] Review Request: clisp - Common Lisp (ANSI CL) implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: clisp - Common Lisp (ANSI CL) implementation


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166004





------- Additional Comments From orion at cora.nwra.com  2005-08-16 10:44 EST -------
I would recommend the following spec layout:

%build
export CFLAGS="$RPM_OPT_FLAGS"
sed -i -e 's|-Wpointer-arith|-Wpointer-arith -falign-functions=4|' \  
   src/makemake.in
./configure --prefix=%{_prefix} --fsstnd=redhat --with-dynamic-ffi \
   --with-dynamic-modules --with-module=regexp --with-module=pcre \
   --with-module=clx/new-clx --with-module=syscalls --with-module=wildcard \
   --with-module=bindings/glibc --with-readline --build

%install
rm -rf ${RPM_BUILD_ROOT}
%makeinstall -C src
rm ${RPM_BUILD_ROOT}/%{_docdir}/doc/clisp.*
%find_lang %{name}
%find_lang %{name}low
cat %{name}low.lang >> %{name}.lang

%files -f %{name}.lang
%defattr(-,root,root,-)
%{_bindir}/clisp
%{_libdir}/clisp
%{_mandir}/man1/*
%{_docdir}/clisp-%{version}/


The export CFLAGS doesn't work quite as well as it should (doesn't end up on
every gcc line).

perl -> sed avoids a BuildRequires: perl

no point in having a define for configure options

%makeinstall macro does what you need.

No need to do the funky %doc moves.  

Use %find_lang instead of listing the locale files.


TODO:

# rpmlint clisp
W: clisp incoherent-version-in-changelog 2.33.2-2 2.33.2-3
W: clisp devel-file-in-non-devel-package /usr/lib/clisp/base/libnoreadline.a
W: clisp devel-file-in-non-devel-package /usr/lib/clisp/base/libavcall.a
W: clisp devel-file-in-non-devel-package /usr/lib/clisp/linkkit/clisp.h
W: clisp devel-file-in-non-devel-package /usr/lib/clisp/linkkit/modules.c
W: clisp devel-file-in-non-devel-package /usr/lib/clisp/full/libavcall.a
W: clisp devel-file-in-non-devel-package /usr/lib/clisp/base/modules.h
W: clisp devel-file-in-non-devel-package /usr/lib/clisp/full/libcallback.a
W: clisp devel-file-in-non-devel-package /usr/lib/clisp/full/lisp.a
W: clisp devel-file-in-non-devel-package /usr/lib/clisp/base/libcharset.a
W: clisp devel-file-in-non-devel-package /usr/lib/clisp/full/modules.h
W: clisp devel-file-in-non-devel-package /usr/lib/clisp/base/libcallback.a
W: clisp devel-file-in-non-devel-package /usr/lib/clisp/base/lisp.a
E: clisp non-executable-script /usr/lib/clisp/clisp-link 0644
W: clisp devel-file-in-non-devel-package /usr/lib/clisp/full/libnoreadline.a
W: clisp devel-file-in-non-devel-package /usr/lib/clisp/full/libcharset.a


I would either put %{_libdir}/clisp into a -devel package or just not ship it at
all.  

Also looks like we need a chmod +x ${RPM_BUILD_ROOT}%{_libdir}/clisp/clisp-link
in %install.




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.