[Bug 165564] Review Request: perl-File-Find-Rule

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-File-Find-Rule


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165564


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-08-16 12:15 EST -------
Review:

- rpmlint clean
- naming of package and spec meets guidelines
- package meets guidelines
- license same as perl
- spec file written in English and is legible
- source matches upstream
- package builds ok in FC4 and in mock for devel (i386)
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership issues
- no duplicate files
- permissions are fine
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime

Nitpick:

- BR: perl not needed
- Finding empty .bs files not needed for noarch package

These can be addressed post-CVS.

I'm happy with this, and will review the BR: perl(Text::Glob) shortly.

Approved.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.