NOT APPROVED: keychain

[Alexander Dalloz]

Am Di, den 16.08.2005 schrieb Ville Skyttä um 21:31:

> > So my proposal is following:
> 
> Just from reading it, makes sense to me.  Go ahead and commit this to
> CVS and I'll test some more.  A few remarks:
> 
> > USERID=`id -un`
> 
> There's also $USER, but I don't know how portable that is.

I played it through all Fedora shells (bash, sh, zsh, csh, tcsh, zsh)
and $USER is available in all. So made the change to the scripts for
more simplicity.
 
> > if [ $HOME == "$USERHOME" -a -f $HOME/.keychainrc ]; then
> 
> AFAIK "==" in comparisons like this is not portable; at least it doesn't
> seem to work in zsh.  Use "=" instead?

Ok, changed as well.

> > I am a bit unsure whether we can catch
> > all possible configurations (what about users stored in LDAP?)
> 
> I think "getent passwd" should return users from LDAP, too.
> 
> >  - but in doubt the opt-in script will simply not run.
> 
> Good.

Commited changes to CVS.

Thanks a lot Ville for helping to get a perfect egg.

Alexander


-- 
 
1024D/866ED681 2005-07-11 Alexander Dalloz (Fedora Project) <alex at dalloz.de>
Key fingerprint = CD40 0A91 7814 C1E4 5940  8E0E 1FD5 C316 866E D681

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050816/6b550ad8/attachment.sig>