[Bug 166087] Review Request: quarry - A multi-purpose board game GUI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: quarry - A multi-purpose board game GUI


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166087


gajownik at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gajownik at gmail.com




------- Additional Comments From gajownik at gmail.com  2005-08-17 05:05 EST -------
Hi!

I don't have rights to make a review but I may help you cleaning up the spec :]

- first of all: read the output from the build process:

 scrollkeeper-update -p /var/scrollkeeper -o
/var/tmp/quarry-0.1.15-1-root-rpm-build/usr/share/omf/quarry
Could not create directory /var/scrollkeeper : Permission denied
Cannot write to log file: /var/log/scrollkeeper.log : Permission denied
Could not create database.  Aborting update.
Cannot write to log file: /var/log/scrollkeeper.log : Permission denied
make[4]: [install-data-hook-omf] Error 1 (ignored)

I have prepared a small patch to resolve this problem. You will also need to add
this stuff:
http://fedoraproject.org/wiki/ScriptletSnippets#head-3c9f517f0cd4aaabb369a8805226d85dc2f02793

warning: File listed twice: /usr/share/omf/quarry/quarry-C.omf
warning: File listed twice: /usr/share/quarry/gtkrc
warning: File listed twice: /usr/share/quarry/help
warning: File listed twice: /usr/share/quarry/help/C
warning: File listed twice: /usr/share/quarry/help/C/fdl.xml
warning: File listed twice: /usr/share/quarry/help/C/figures
warning: File listed twice: /usr/share/quarry/help/C/figures/control-center.png
warning: File listed twice: /usr/share/quarry/help/C/legal.xml
warning: File listed twice: /usr/share/quarry/help/C/quarry.html
warning: File listed twice: /usr/share/quarry/help/C/quarry.xml
warning: File listed twice: /usr/share/quarry/help/quarry-help.css
warning: File listed twice: /usr/share/quarry/markup-themes
warning: File listed twice: /usr/share/quarry/markup-themes/bold
warning: File listed twice: /usr/share/quarry/markup-themes/bold/circle.svg
warning: File listed twice: /usr/share/quarry/markup-themes/bold/cross.svg
warning: File listed twice: /usr/share/quarry/markup-themes/bold/last-move.svg
warning: File listed twice: /usr/share/quarry/markup-themes/bold/selected.svg
warning: File listed twice: /usr/share/quarry/markup-themes/bold/square.svg
warning: File listed twice: /usr/share/quarry/markup-themes/bold/theme.cfg
warning: File listed twice: /usr/share/quarry/markup-themes/bold/triangle.svg
warning: File listed twice: /usr/share/quarry/markup-themes/default
warning: File listed twice: /usr/share/quarry/markup-themes/default/circle.svg
warning: File listed twice: /usr/share/quarry/markup-themes/default/cross.svg
warning: File listed twice: /usr/share/quarry/markup-themes/default/last-move.svg
warning: File listed twice: /usr/share/quarry/markup-themes/default/selected.svg
warning: File listed twice: /usr/share/quarry/markup-themes/default/square.svg
warning: File listed twice: /usr/share/quarry/markup-themes/default/theme.cfg
warning: File listed twice: /usr/share/quarry/markup-themes/default/triangle.svg
warning: File listed twice: /usr/share/quarry/markup-themes/filled
warning: File listed twice: /usr/share/quarry/markup-themes/filled/circle.svg
warning: File listed twice: /usr/share/quarry/markup-themes/filled/cross.svg
warning: File listed twice: /usr/share/quarry/markup-themes/filled/last-move.svg
warning: File listed twice: /usr/share/quarry/markup-themes/filled/selected.svg
warning: File listed twice: /usr/share/quarry/markup-themes/filled/square.svg
warning: File listed twice: /usr/share/quarry/markup-themes/filled/theme.cfg
warning: File listed twice: /usr/share/quarry/markup-themes/filled/triangle.svg
warning: File listed twice: /usr/share/quarry/textures
warning: File listed twice: /usr/share/quarry/textures/wood1.jpg
warning: File listed twice: /usr/share/quarry/textures/wood2.jpg

You should wrote:

%{_datadir}/omf/quarry/
%{_datadir}/quarry/

instead of:

%{_datadir}/omf/quarry
%{_datadir}/omf/quarry/quarry*.omf
%{_datadir}/quarry
%{_datadir}/quarry/*

Michael Schwendt gave a good explanation of this problem here →
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165616#c8

- use variables in "Source0" tag. You will have less work with new releases:

Source0:        http://download.gna.org/quarry/%{name}-%{version}.tar.gz

- use %find_lang macro
- please provide menu entry:
http://fedoraproject.org/wiki/Extras/FedoraDesktopEntryGuidelines
- you don't have to add dist tag in the changelog

Everything else looks good to me :]

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.