Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Sort-Versions
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165553
paul at city-fan.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |paul at city-fan.org
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From paul at city-fan.org 2005-08-17 08:52 EST -------
Review:
- rpmlint clean
- naming of package and spec meets guidelines
- package meets guidelines
- license same as perl
- spec file written in English and is legible
- source matches upstream
- package builds ok in FC4 and in mock for devel (i386)
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership issues
- no duplicate files
- permissions are fine
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
Issues:
- rpmlint not clean:
E: perl-Sort-Versions non-executable-script
/usr/lib/perl5/vendor_perl/5.8.6/Sort/Versions.pm 0644
This script is not executable
I believe this is a spurious error caused by the shebang at the start of the
file, but you could get rid of it anyway by appending to %prep:
%{__perl} -ni -e 'print if (2 .. eof());' Versions.pm
or something equivalent.
- suggest adding README as %doc
- BR: perl redundant
- Finding empty .bs files not needed for noarch package
These can be addressed post-CVS.
I'm happy with this.
Approved.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.