[Bug 166197] Review Request: perl-Class-Trigger : Mixin to add / call inheritable triggers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-Trigger : Mixin to add / call inheritable triggers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166197





------- Additional Comments From chris at chrisgrau.com  2005-08-17 18:04 EST -------
Review:

- rpmlint clean
- good package name
- good spec file name
- acceptible license
- license matches upstream
- spec file is am. english (and is legible)
- source matches upstream
- package builds on FC-4
- no locales
- no shared libs
- not relocatable
- owns all created directories
- no duplicate %files
- file permissions okay
- %clean okay
- consistent use of macros
- contains code, not content
- no -docs package
- %doc okay
- no -devel package

Needswork:

BuildRequires: perl >= 1:5.6.1

Is this necessary?  Perl is a given for rpm-build and Class::Trigger doesn't
explicitly require a minimum version.

Makefile.PL lists Class::Data::Inheritable >= 0.02 as a requirement, but it's
not listed as a BR (nor does it build without it installed).

In %build, make is given without %{_smp_mflags}.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.