[Bug 166202] Review Request: perl-Template-Plugin-Class : Allow calling of class methods on arbitrary classes
bugzilla at redhat.com
bugzilla at redhat.com
Wed Aug 17 22:40:58 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Template-Plugin-Class : Allow calling of class methods on arbitrary classes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166202
------- Additional Comments From chris at chrisgrau.com 2005-08-17 18:40 EST -------
Review:
- rpmlint clean
- good package name
- good spec file name
- good license
- license matches upstream
- spec is am. english (and legible)
- source matches upstream (and is latest version)
- package builds on FC-4
- no locales
- no shared libs
- not relocatable
- no duplicate %files
- file permissions okay
- %clean okay
- consistent use of macros
- code, not content
- no -docs package
- %doc okay
- no -devel package
Needswork:
I was prompted to install Module::Build when running rpmbuild. This should be
in the BR.
> BuildRequires: perl >= 1:5.6.1
Is this BR necessary?
make does not include %{?_smp_mflags}.
> $ rpm -qf /usr/lib/perl5/vendor_perl/5.8.6/Template
> file /usr/lib/perl5/vendor_perl/5.8.6/Template is not owned by any package
perl-Template-Toolkit installs to %{perl_vendorarch} instead of
%{perl_vendorlib}, so it doesn't create/own this Template directory.
RPM doesn't automatically pick up the requires on perl(Template). Should
probably be added explicitly.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list