[Bug 166197] Review Request: perl-Class-Trigger : Mixin to add / call inheritable triggers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-Trigger : Mixin to add / call inheritable triggers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166197


chris at chrisgrau.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From chris at chrisgrau.com  2005-08-17 18:47 EST -------
(In reply to comment #2)
> The BuildRequires: perl >= 1:5.6.1 is in the spec template... but I doubt we
> need it.
> 
> (perl spec template here: http://gsd.di.uminho.pt/jpo/perl/specfiles/)

I used to use the same BR for perl.  The spectemplate-perl.spec in the
fedora-rpmdevtools package only lists "BuildRequires: perl."  I think it's
redundant, but probably there for looks in a perl-* package.  I noticed that
perl is already a requirement for rpm-build, so the whole thing is pretty silly.

> I didn't see any reason to use _smp_mflags for a noarch perl package that just
> runs a cp command when make is triggered... but for consistency, I've added it. :)

Agreed, it's pointless in such a case.  I would have approved either way. :)

> Good catch on C::D::I, i've added it as a BR.
> 
> New SRPM:
>
http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-Trigger-0.09-3.src.rpm
> 
> New SPEC:
> http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-Trigger.spec

And with that, APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.