[Bug 166198] Review Request: perl-DBIx-ContextualFetch : Add contextual fetches to DBI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DBIx-ContextualFetch : Add contextual fetches to DBI


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166198





------- Additional Comments From chris at chrisgrau.com  2005-08-17 20:05 EST -------
Review:

- rpmlint clean
- package name okay
- spec file name okay
- license okay
- license matches upstream
- spec file in am. english (and legible)
- source matches upstream
- package builds on FC-4
- no locales
- no shared libs
- not relocatable
- all created directories owned
- no duplicate %files
- file permissions okay
- %clean okay
- consistent use of macros
- code, not content
- no -docs
- no -devel

Needswork:

DBI is a requirement in Makefile.PL, but is not listed as a BR.  However, the
package does build without perl-DBI, but only due to the fact that the tests are
skipped without DBD::SQLite2 installed.  Since DBD::SQLite2 is available in
extras, I think it should be a BR for complete test coverage.

perl(DBI) is not automatically picked up as a requires, so it should be
explicitly added.  I've found this to be a deficiency in RPM that it doesn't
automatically pick up modules found in "use base" declarations.

Nitpicks:

- BuildRequires: perl >= 1:5.6.1
- make called without %{?_smp_mflags}

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.