[Bug 165660] Review Request: perl-Text-Quoted

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Text-Quoted


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165660


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-08-19 08:10 EST -------
Review:

- rpmlint not quite clean - see below
- package and spec file naming is OK
- package meets guidelines
- license is same as perl
- spec file written in English and is legible
- source matches upstream
- builds OK on FC4 and in mock for devel
- BR's OK
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership issues
- Quoted.pm installed with wrong permissions - see below
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime

Issues:

- rpmlint output
E: perl-Text-Quoted script-without-shellbang
/usr/lib/perl5/vendor_perl/5.8.6/Text/Quoted.pm
This script does not begins with a shellbang. It will prevent its execution.

This is a permissions problem and can be fixed by adding after %setup:
chmod -x Quoted.pm

- BR: perl is redundant
- find of empty .bs files is redundant

These can be fixed post-import.

Approved.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.