[Bug 165662] Review Request: perl-Regexp-Common
bugzilla at redhat.com
bugzilla at redhat.com
Fri Aug 19 17:15:55 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Regexp-Common
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165662
paul at city-fan.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |paul at city-fan.org
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From paul at city-fan.org 2005-08-19 13:15 EST -------
Review:
- rpmlint not quite clean - see below
- package and spec file naming is OK
- package meets guidelines
- license is Artistic (only)
- spec file written in English and is legible
- source matches upstream
- builds OK on FC4 and in mock for devel
- BR's OK
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
Issues:
- rpmlint output
W: perl-Regexp-Common incoherent-version-in-changelog 1.120-1 2.120-1
Your last entry in %changelog contains a version that is not coherent with the
current version of your package.
This is just a typo in both of the specfile changelog entries.
- BR: perl is redundant
- find of empty .bs files is redundant
- suggest for %files:
%{perl_vendorlib}/Regexp/
rather than
%{perl_vendorlib}/*
These can be fixed post-import.
Approved.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list