[Bug 166252] Review Request: perl-Gnome2-Canvas

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Gnome2-Canvas


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166252





------- Additional Comments From jspaleta at gmail.com  2005-08-19 19:25 EST -------
okay it builds in mock and outside of mock on a development i386 box
rpmlint perl-Gnome2-Canvas-1.002-3.fc5.i386.rpm
E: perl-Gnome2-Canvas zero-length
/usr/share/doc/perl-Gnome2-Canvas-1.002/canvas_demo/ENTRYPOINT_IS_canvas.pl

 Is this really a zero-length file or a strange build error? If its really zero
length its probably best to exclude it.

W: perl-Gnome2-Canvas devel-file-in-non-devel-package
/usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/Gnome2/Canvas/Install/gnomecanvasperl-autogen.h
W: perl-Gnome2-Canvas devel-file-in-non-devel-package
/usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/Gnome2/Canvas/Install/gnomecanvasperl-version.h
W: perl-Gnome2-Canvas devel-file-in-non-devel-package
/usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/Gnome2/Canvas/Install/gnomecanvasperl.h

Ignorable for perl packages as best that i can determine looking at other perl
packages in extras.


Good:
packagename meets perl naming guidelines
the spec file name matches the packagename
license tag matches included License file
legible spec file
source and upstream source md5sums match 93405a987ba4bbd03c2f91592b88f5cb
buildrequires look sane
no shared libraries in linker path
packages owns all the directories it creates appropriately
permissions look appropriate.. no executable scripts are part of this package.
clean and check correct in specfile


I take it chmod -R u+w $RPM_BUILD_ROOT/* in the specfile is there to work around
a problem with the make test or the clean?

I'm not seeing any major blockers here. I suspect the problems in comment 2 are
some sort of arch specific problem in Core development which I can't see on x86.

I'll hold off on flipping the approval bit for 12 hours or so, to see if any
other blocker comments show up.  The only minor problem i see is the one zero
length file.

-jef

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.