[Bug 166252] Review Request: perl-Gnome2-Canvas

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Gnome2-Canvas


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166252





------- Additional Comments From jspaleta at gmail.com  2005-08-20 01:05 EST -------
(In reply to comment #5)
> When you check the build logs, you'll notice that -pthread is being used 
> during compilation:

grrr... i totally missed that when i looked over the build log.. i must of fat
fingered the grep for pthread when i looked for this earlier. Sorry about that.
I think we are definitely going to have to have an impact assessment before this
leaves review.

One thing to note ldd Canvas.so  shows
libpthread.so.0 => /lib/libpthread.so.0 (0x009d9000)

and the demo canvas.pl script seems to be operating well. Everything in the
demos seems to work and its throwing some rather mundane errors:
Use of uninitialized value in subtraction (-) at canvas-primitives.pl line 386
Use of uninitialized value in subroutine entry at canvas-primitives.pl line 410
Use of uninitialized value in subroutine entry at canvas-primitives.pl line 400
Use of uninitialized value in numeric eq (==) at canvas-curve.pl line 138

What do you think? Is this a good enough assessment as to impact on
functionality? Or do we need to ask the submitter to attempt to get
clarification from the upstream author about the  LIBS ignored: '-pthread' message?

(In reply to comment #6 and #7)
good catch. One question, the spectemplate-perl.spec from fedora-rpmdevtools 
uses make %{?_smp_mflags} OPTIMIZE="$RPM_OPT_FLAGS"  I take it either form is
equivalent? 


-jef

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.